style: make ansible-lint happier

bittorrent.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: transmission
+- name: Transmission
+  hosts: transmission
   diff: true
   roles:
     - bittorrent

borgbackup.yml

@@ -1,14 +1,17 @@
 ---
 
-- hosts: borgbackup
+- name: Borgbackup
+  hosts: borgbackup
   diff: true
   roles:
       - borgbackup
-- hosts: borg_client
+- name: Borg clients
+  hosts: borg_client
   diff: true
   roles:
       - borg_client
-- hosts: borg_server
+- name: Borg server
+  hosts: borg_server
   diff: true
   roles:
       - borg_server

docker.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: dockerservers
+- name: Docker
+  hosts: dockerservers
   diff: true
   roles:
       - docker

firewall.yml

@@ -1,11 +1,14 @@
 ---
 
-- hosts: all:!baybay-ponay.mateu.be:!machinbox.mateu.be:!muse-HP-EliteBook-820-G2.home.arpa
+- name: Retrieve network info
+  hosts: all:!baybay-ponay.mateu.be:!machinbox.mateu.be:!muse-HP-EliteBook-820-G2.home.arpa
   gather_facts: true
   gather_subset:
     - network
   tasks: []
-- hosts: router
+
+- name: Router
+  hosts: router
   diff: true
   roles:
     - firewall

ftp.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: ftpservers
+- name: FTP
+  hosts: ftpservers
   diff: true
   roles:
       - ftp

garage.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: garageservers
+- name: Garage
+  hosts: garageservers
   diff: true
   roles:
     - garage

icecast2.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: icecastservers
+- name: Icecast
+  hosts: icecastservers
   diff: true
   roles:
       - icecast2

loadbalancinghttp.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: loadbalancers
+- name: Load balancers
+  hosts: loadbalancers
   diff: true
   roles:
     - haproxy

mail.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: mailservers
+- name: Mail
+  hosts: mailservers
   diff: true
   roles:
     - postfix

mariadb.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: mariadbservers
+- name: MariaDB
+  hosts: mariadbservers
   diff: true
   roles:
     - mariadb

mastodon.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: mastodonservers
+- name: Mastodon
+  hosts: mastodonservers
   diff: true
   roles:
     - mastodon

mumble.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: mumbleservers
+- name: Mumble
+  hosts: mumbleservers
   diff: true
   roles:
       - mumble

munin.yml

@@ -1,11 +1,13 @@
 ---
 
-- hosts: all:!disabled_munin
+- name: Munin clients
+  hosts: all:!disabled_munin
   diff: true
   roles:
     - munin_client
 
-- hosts: muninservers
+- name: Munin servers
+  hosts: muninservers
   diff: true
   roles:
     - munin_server

nut.yml

@@ -1,10 +1,12 @@
 ---
 
-- hosts: nut_server
+- name: NUT server
+  hosts: nut_server
   diff: true
   roles:
       - nut_server
-- hosts: nut_client
+- name: NUT clients
+  hosts: nut_client
   diff: true
   roles:
       - nut_client

pgsql.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: pgsqlservers
+- name: PostgreSQL
+  hosts: pgsqlservers
   diff: true
   roles:
       - postgres

php.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: phpservers
+- name: PHP
+  hosts: phpservers
   diff: true
   roles:
     - php

restic.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: resticservers
+- name: Restic
+  hosts: resticservers
   diff: true
   roles:
     - restic

roles/bittorrent/handlers/main.yml

@@ -1,14 +1,16 @@
 ---
 
-- name: reload transmission
+- name: Reload transmission
-  service:
+  ansible.builtin.service:
     name: transmission-daemon
     state: reloaded
 
-- name: restart sonarr
+- name: Restart sonarr
-  service:
+  ansible.builtin.service:
     name: sonarr
     state: restarted
 
-- name: export nfs
+- name: Export nfs
-  command: exportfs -a
+  ansible.builtin.command:
+    cmd: exportfs -a
+  changed_when: true

roles/bittorrent/tasks/configdir.yml

@@ -1,14 +1,14 @@
 ---
 
-- name: create Series folder
+- name: Create Series folder
-  file:
+  ansible.builtin.file:
     path: /var/lib/transmission-daemon/downloads/Series
     recurse: true
     owner: debian-transmission
     group: debian-transmission
 
-- name: create Movies folder
+- name: Create Movies folder
-  file:
+  ansible.builtin.file:
     path: /var/lib/transmission-daemon/downloads/Movies
     recurse: true
     owner: debian-transmission

roles/bittorrent/tasks/main.yml

@@ -1,7 +1,12 @@
 ---
 
-- include_tasks: transmission.yml
+- name: Include transmission
-- include_tasks: sonarr.yml
+  ansible.builtin.include_tasks: transmission.yml
-- include_tasks: subliminal.yml
+- name: Include sonarr
-- include_tasks: configdir.yml
+  ansible.builtin.include_tasks: sonarr.yml
-- include_tasks: nfsserver.yml
+- name: Include subliminal
+  ansible.builtin.include_tasks: subliminal.yml
+- name: Include configdir
+  ansible.builtin.include_tasks: configdir.yml
+- name: Include nfsserver
+  ansible.builtin.include_tasks: nfsserver.yml

roles/bittorrent/tasks/nfsserver.yml

@@ -1,17 +1,19 @@
 ---
 
-- getent:
+- name: Get debian-transmission id
+  ansible.builtin.getent:
     database: passwd
     key: debian-transmission
 
-- name: install nfs server
+- name: Install nfs server
-  package:
+  ansible.builtin.package:
     name: nfs-kernel-server
     state: present
 
-- name: copy exports file
+- name: Copy exports file
-  template:
+  ansible.builtin.template:
     src: exports.j2
     dest: /etc/exports
+    mode: 0644
   notify:
-    - export nfs
+    - Export nfs

roles/bittorrent/tasks/sonarr.yml

@@ -1,29 +1,29 @@
 ---
 
-- name: install sonarr repokey
+- name: Install sonarr repokey
-  apt_key:
+  ansible.builtin.apt_key:
     keyserver: keyserver.ubuntu.com
     id: "0xa236c58f409091a18aca53cbebff6b99d9b78493"
 
-- name: install sonarr repo
+- name: Install sonarr repo
-  apt_repository:
+  ansible.builtin.apt_repository:
     repo: deb http://apt.sonarr.tv/debian buster-develop main
     state: present
 
-- name: create sonarr conf dir
+- name: Create sonarr conf dir
-  file:
+  ansible.builtin.file:
     path: /var/lib/transmission-daemon/.config/NzbDrone
     recurse: true
     owner: debian-transmission
     group: debian-transmission
     mode: "a-rwx,u+rwX,g+rX"
 
-- name: install sonarr
+- name: Install sonarr
-  package:
+  ansible.builtin.package:
     name: sonarr
     state: present
 
-- name: enable sonarr service
+- name: Enable sonarr service
-  service:
+  ansible.builtin.service:
     name: sonarr
     enabled: true

roles/bittorrent/tasks/subliminal.yml

@@ -1,17 +1,17 @@
 ---
 
-- name: install pip3
+- name: Install pip3
-  package:
+  ansible.builtin.package:
     name: python3-pip
     state: present
 
-- name: install subliminal
+- name: Install subliminal
-  pip:
+  ansible.builtin.pip:
     name: subliminal
     state: present
 
-- name: install subliminal crontab
+- name: Install subliminal crontab
-  cron:
+  ansible.builtin.cron:
     name: "Sub DL"
     user: "debian-transmission"
     minute: "15"

roles/bittorrent/tasks/transmission.yml

@@ -1,25 +1,25 @@
 ---
 
-- name: install transmission
+- name: Install transmission
-  package:
+  ansible.builtin.package:
     name: "{{ item }}"
     state: present
   loop:
     - transmission-daemon
     - transmission-cli
 
-- name: transmission config file
+- name: Transmission config file
-  template:
+  ansible.builtin.template:
     src: settings.json.j2
     dest: /etc/transmission-daemon/settings.json
     owner: debian-transmission
     group: debian-transmission
     mode: "a-rwx,u+rw"
   notify:
-    - reload transmission
+    - Reload transmission
 
 - name: Add cachedir file
-  copy:
+  ansible.builtin.copy:
     src: files/CACHEDIR.TAG
     dest: /var/lib/transmission-daemon/downloads/CACHEDIR.TAG
     owner: debian-transmission

roles/borg_client/tasks/main.yml

@@ -1,28 +1,30 @@
 ---
 
-- name: create SSH key
+- name: Create SSH key
-  openssh_keypair:
+  community.crypto.openssh_keypair:
     path: ~/.ssh/id_rsa
 
-- name: get SSH pub key
+- name: Get SSH pub key
-  command: cat ~/.ssh/id_rsa.pub
+  ansible.builtin.command:
+    cmd: cat ~/.ssh/id_rsa.pub
+  changed_when: true
   register: ssh_keys
 
-- name: put backup script
+- name: Put backup script
-  template:
+  ansible.builtin.template:
     src: borgbackup.sh.j2
     dest: /usr/local/bin/borgbackup.sh
     owner: root
     group: root
     mode: '0750'
 
-- name: cron the backup script
+- name: Cron the backup script
-  cron:
+  ansible.builtin.cron:
     name: "borg backup script"
     hour: "{{ borg_backup_hour }}"
     minute: "{{ borg_backup_minute }}"
     job: /usr/local/bin/borgbackup.sh
 
-- name: warns about borg init
+- name: Warns about borg init
-  debug:
+  ansible.builtin.debug:
     msg: "Borg has been installed. Don’t forget to init with: \nborg init --encryption=repokey-blake2 backup@{{ hostvars[groups['borg_server'][0]]['ansible_fqdn'] }}:home"

roles/borg_server/tasks/main.yml

@@ -1,15 +1,15 @@
 ---
 
-- name: mount backup disk
+- name: Mount backup disk
-  mount:
+  ansible.posix.mount:
     path: /backup
     src: LABEL=BACKUP
     fstype: ext4
     opts: noatime,nofail
     state: mounted
 
-- name: create backup user
+- name: Create backup user
-  user:
+  ansible.builtin.user:
     name: backup
     comment: Backup
     create_home: true
@@ -18,8 +18,8 @@
     system: true
     state: present
 
-- name: "create directory for borg clients"
+- name: Create directory for borg clients
-  file:
+  ansible.builtin.file:
     path: "/backup/repos/{{ hostvars[item]['ansible_fqdn'] }}"
     state: directory
     mode: '0750'
@@ -27,8 +27,8 @@
     group: backup
   loop: "{{ groups['borg_client'] }}"
 
-- name: "set authorized_keys for borg clients"
+- name: Set authorized_keys for borg clients
-  authorized_key:
+  ansible.posix.authorized_key:
     user: backup
     key: "{{ hostvars[item]['ssh_keys']['stdout'] }}"
     key_options: "command=\"cd /backup/repos/{{ hostvars[item]['ansible_fqdn'] }}; borg serve --restrict-to-path /backup/repos/{{ hostvars[item]['ansible_fqdn'] }}\""

roles/borgbackup/tasks/main.yml

@@ -1,12 +1,16 @@
 ---
 
-- set_fact:
+- name: Set borg fact
+  ansible.builtin.set_fact:
     borgbackup: borg
     when: ansible_facts['distribution'] == "Archlinux"
-- set_fact:
+
+- name: Set borgbackup fact
+  ansible.builtin.set_fact:
     borgbackup: borgbackup
     when: ansible_facts['distribution'] == "Debian"
-- name: install borg package
+
-  package:
+- name: Install borg package
+  ansible.builtin.package:
     name: "{{ borgbackup }}"
     state: present