feat: make ansible-lint happier

roles/munin_client/tasks/hypervisors.yml

@@ -0,0 +1,11 @@
+---
+
+- name: delete squid plugins
+  shell: "rm -f /etc/munin/plugins/squid_*"
+  notify:
+    - restart munin-node
+
+- name: delete lxc interfaces plugins
+  shell: "rm -f /etc/munin/plugins/if_*veth* /etc/munin/plugins/if_*fw* /etc/munin/plugins/if_*vmbr*"
+  notify:
+    - restart munin-node

roles/munin_client/tasks/main.yml

@@ -0,0 +1,126 @@
+---
+
+- set_fact:
+    muninpkgs:
+      - muninlite
+    munin_need_reconfigure: false
+  when: ansible_facts['distribution'] == "LEDE" or ansible_facts['distribution'] == "OpenWRT" or ansible_facts['distribution'] == "OpenWrt"
+
+- set_fact:
+    muninpkgs:
+      - munin-node
+      - munin-plugins-core
+      - munin-plugins-extra
+    munin_need_reconfigure: true
+  when: ansible_facts['distribution'] == "Debian"
+
+- name: install munin node packages
+  package:
+    name: "{{ item }}"
+    state: present
+  loop: "{{ muninpkgs }}"
+
+- name: munin-node conf file
+  template:
+    src: munin-node.conf.j2
+    dest: /etc/munin/munin-node.conf
+  notify:
+    - restart munin-node
+  when: munin_need_reconfigure
+
+## Adding modules for specific functions
+# for NginX webservers
+- name: install LWP::UserAgent
+  package:
+    name: libwww-perl
+    state: present
+  notify:
+    - restart munin-node
+  when: "'webservers' in group_names or 'loadbalancers' in group_names"
+
+# for HAProxy servers
+- name: add HAProxy backend module
+  file:
+    src: /usr/share/munin/plugins/haproxy_
+    dest: /etc/munin/plugins/haproxy_current
+    state: link
+  notify:
+    - restart munin-node
+  when: "'loadbalancers' in group_names"
+
+# For MariaDB servers
+- name: install Cache::Cache
+  package:
+    name: libcache-cache-perl
+    state: present
+  notify:
+    - restart munin-node
+  when: "'mariadbservers' in group_names"
+
+# For PGSQL servers
+- name: install DBD::Pg
+  package:
+    name: libdbd-pg-perl
+    state: present
+  notify:
+    - restart munin-node
+  when: "'pgsqlservers' in group_names"
+
+# For Munin servers
+- name: execute specific tasks for munin servers
+  include_tasks: mikrotik.yml
+  when: "'muninservers' in group_names"
+
+# for NUT (UPS) servers
+- name: "add specific nut value for UPS"
+  file:
+    path: "/etc/munin/plugins/nutups_eaton3s_{{ item }}"
+    src: /usr/share/munin/plugins/nutups_
+    state: link
+  notify:
+    - restart munin-node
+  when: "'nut_server' in group_names"
+  loop:
+    - charge
+    - voltages
+
+# for physical servers
+- name: execute specific tasks for physical servers
+  include_tasks: physical_servers.yml
+  when: "'hypervisors' in group_names"
+
+- name: reconfigure munin-node
+  shell:
+    cmd: munin-node-configure --shell | sh
+  notify:
+    - restart munin-node
+  when: munin_need_reconfigure
+
+## Useless junks for everyone
+- name: delete useless junks for everyone
+  file:
+    path: "/etc/munin/plugins/{{ item }}"
+    state: absent
+  when: munin_need_reconfigure
+  loop:
+    - users
+
+## Useless junks for LXC
+- name: "delete junks from LXC machines"
+  file:
+    path: "/etc/munin/plugins/{{ item }}"
+    state: absent
+  notify:
+    - restart munin-node
+  when: ansible_facts['virtualization_type'] == "lxc"
+  loop:
+    - acpi
+    - cpuspeed
+    - diskstats
+    - entropy
+    - irqstats
+
+## Useless junks for hypervisors
+- name: execute delete states for hypervisors
+  include_tasks: hypervisors.yml
+  when: "'hypervisors' in group_names"

roles/munin_client/tasks/mikrotik.yml

@@ -0,0 +1,21 @@
+---
+
+- name: deploy mikrotik unitary scripts
+  copy:
+    src: "./files/{{ item.0 }}"
+    dest: "/etc/munin/plugins/{{ item.0 }}{{ item.1.name }}"
+    mode: 0755
+  loop: "{{ mikrotik_unitary_scripts|product(mikrotik_hosts)|list }}"
+  notify:
+    - restart munin-node
+
+- name: deploy mikrotik per iface scripts
+  copy:
+    src: "./files/{{ item.1 }}"
+    dest: "/etc/munin/plugins/{{ item.1 }}{{ item.0.0.name }}_{{ item.0.1 }}"
+    mode: 0755
+  loop: "{{ mikrotik_hosts|subelements('ifaces')|product(mikrotik_periface_scripts) }}"
+  loop_control:
+    label: "{{ item.0.1 }}"
+  notify:
+    - restart munin-node

roles/munin_client/tasks/physical_servers.yml

@@ -0,0 +1,16 @@
+---
+# for physical servers
+- name: install necessary packages for hypervisors
+  package:
+    name: lm-sensors
+    state: present
+
+- name: configure specific munin plugin
+  file:
+    path: "/etc/munin/plugins/sensors_{{ item }}"
+    src: /usr/share/munin/plugins/sensors_
+    state: link
+  notify:
+    - restart munin-node
+  loop:
+    - temp