style: make ansible-lint happier

roles/docker/tasks/main.yml

@@ -1,17 +1,17 @@
 ---
 
-- name: docker repo key
+- name: Docker repo key
-  apt_key:
+  ansible.builtin.apt_key:
     url: https://download.docker.com/linux/debian/gpg
     state: present
 
-- name: docker repo install
+- name: Docker repo install
-  apt_repository:
+  ansible.builtin.apt_repository:
     repo: "deb [arch=amd64] https://download.docker.com/linux/debian {{ ansible_facts['distribution_release'] }} stable"
     state: present
 
-- name: install docker, docker-compose and extra packages
+- name: Install docker, docker-compose and extra packages
-  package:
+  ansible.builtin.package:
     name: "{{ item }}"
     state: present
   loop:
@@ -21,9 +21,10 @@
     - docker-compose
     - fuse-overlayfs
 
-- name: docker directory
+- name: Docker directory
-  file:
+  ansible.builtin.file:
     path: /srv/docker
     owner: root
     group: root
     state: directory
+    mode: 0755

roles/dovecot/handlers/main.yml

@@ -1,9 +1,11 @@
 ---
 
-- name: restart dovecot
+- name: Restart dovecot
-  service:
+  ansible.builtin.service:
     name: dovecot
     state: restarted
 
-- name: compile sieve
+- name: Compile sieve
-  command: sievec /etc/dovecot/before.sieve
+  ansible.builtin.command:
+    cmd: sievec /etc/dovecot/before.sieve
+  changed_when: true

roles/dovecot/tasks/main.yml

@@ -1,6 +1,6 @@
 ---
-- name: install dovecot
+- name: Install dovecot
-  package:
+  ansible.builtin.package:
     name: "{{ item }}"
     state: present
   loop:
@@ -8,17 +8,19 @@
     - dovecot-sieve
     - dovecot-lmtpd
 
-- name: main configuration file
+- name: Main configuration file
-  copy:
+  ansible.builtin.copy:
     src: ./files/dovecot.conf
     dest: /etc/dovecot/dovecot.conf
+    mode: 0644
   notify:
-    - restart dovecot
+    - Restart dovecot
 
-- name: sieve configuration file
+- name: Sieve configuration file
-  copy:
+  ansible.builtin.copy:
     src: ./files/before.sieve
     dest: /etc/dovecot/before.sieve
+    mode: 0644
   notify:
-    - compile sieve
+    - Compile sieve
-    - restart dovecot
+    - Restart dovecot

roles/firewall/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 
-- name: reload firewall
+- name: Reload firewall
-  openwrt_init:
+  community.general.openwrt_init:
     name: firewall
     state: reloaded

roles/firewall/tasks/main.yml

@@ -1,7 +1,8 @@
 ---
 
-- name: generate firewall file
+- name: Generate firewall file
-  template:
+  ansible.builtin.template:
     src: firewall.j2
     dest: /etc/config/firewall
-  notify: reload firewall
+    mode: 0644
+  notify: Reload firewall

roles/ftp/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 
-- name: restart vsftpd
+- name: Restart vsftpd
-  service:
+  ansible.builtin.service:
     name: vsftpd
     state: restarted

roles/ftp/tasks/main.yml

@@ -1,32 +1,35 @@
 ---
 
 - name: Install vsftpd
-  package:
+  ansible.builtin.package:
     name: vsftpd
     state: present
 
 - name: Create ftp directory
-  file:
+  ansible.builtin.file:
     path: /srv/ftp
     state: directory
+    mode: 0755
 
 - name: Create upload directory
-  file:
+  ansible.builtin.file:
     path: /srv/ftp/upload
     owner: ftp
     group: root
     state: directory
+    mode: 0755
 
 - name: Config vsftpd
-  copy:
+  ansible.builtin.copy:
     src: files/vsftpd.conf
     dest: /etc/vsftpd.conf
     owner: root
     group: root
-  notify: restart vsftpd
+    mode: 0755
+  notify: Restart vsftpd
 
 - name: Put control size script
-  copy:
+  ansible.builtin.copy:
     src: files/deleteoldfiles.sh
     dest: /usr/local/sbin/deleteoldfiles.sh
     owner: root
@@ -34,7 +37,7 @@
     mode: '0700'
 
 - name: Cron control size script
-  cron:
+  ansible.builtin.cron:
     name: Delete oldest file
     user: root
     minute: '0'