style: make ansible-lint happier

roles/mariadb/handlers/main.yml

@@ -1,9 +1,10 @@
 ---
 
-- name: restart mariadb
-  service:
+- name: Restart mariadb
+  ansible.builtin.service:
     name: mariadb
     state: restarted
 
-- name: daemon-reload
-  command: systemctl daemon-reload
+- name: Daemon-reload
+  ansible.builtin.systemd:
+    daemon_reload: true

roles/mariadb/tasks/main.yml

@@ -1,67 +1,69 @@
 ---
 
-- name: install mariadb
-  package:
+- name: Install mariadb
+  ansible.builtin.package:
     name: mariadb-server
     state: present
 
-- name: create mysql directory
-  file:
+- name: Create mysql directory
+  ansible.builtin.file:
     path: /srv/mysql
     owner: mysql
     group: mysql
     state: directory
+    mode: 0755
 
-- name: populate mysql directory
-  command: /usr/bin/mysql_install_db --datadir=/srv/mysql
-  args:
+- name: Populate mysql directory
+  ansible.builtin.command:
+    cmd: /usr/bin/mysql_install_db --datadir=/srv/mysql
     creates: /srv/mysql/ibdata1
-  notify: restart mariadb
+  notify: Restart mariadb
 
-- name: replace conffile
-  template:
+- name: Replace conffile
+  ansible.builtin.template:
     src: 50-server.cnf.j2
     dest: /etc/mysql/mariadb.conf.d/50-server.cnf
-  notify: restart mariadb
+    mode: 0644
+  notify: Restart mariadb
 
-- name: debian upgrade file conf
-  template:
+- name: Debian upgrade file conf
+  ansible.builtin.template:
     src: debian.cnf.j2
     dest: /etc/mysql/debian.cnf
     owner: root
     group: root
     mode: '0600'
-  notify: restart mariadb
+  notify: Restart mariadb
 
-- name: force handlers
-  meta: flush_handlers
+- name: Force handlers
+  ansible.builtin.meta: flush_handlers
 
-- name: install python-mysql
-  package:
+- name: Install python-mysql
+  ansible.builtin.package:
     name: python3-pymysql
     state: present
 
-- name: check if .my.cnf file exists
-  stat:
+- name: Check if .my.cnf file exists
+  ansible.builtin.stat:
     path: /root/.my.cnf
   register: dot_my_cnf
 
-- name: root password
-  mysql_user:
+- name: Root password
+  community.mysql.mysql_user:
     login_unix_socket: "/var/run/mysqld/mysqld.sock"
     host: localhost
     name: root
     password: "{{ mariadb_root_pass }}"
-  when: dot_my_cnf.stat.exists == False
+  when: not dot_my_cnf.stat.exists
 
-- name: put .my.cnf file
-  template:
+- name: Put .my.cnf file
+  ansible.builtin.template:
     src: dot.my.cnf.j2
     dest: ~/.my.cnf
     mode: '0600'
 
-- name: root password (follow-up)
-  mysql_user:
+- name: Root password (follow-up)
+  community.mysql.mysql_user:
     login_user: root
     host: "{{ item }}"
     name: root
@@ -71,9 +73,9 @@
     - "127.0.0.1"
     - "::1"
 
-- name: scripted version of mysql_secure_installation
-  shell: "{{ item }}"
-  args:
+- name: Scripted version of mysql_secure_installation
+  ansible.builtin.command:
+    cmd: "{{ item }}"
     creates: ~/mysql_secure_installation
   loop:
     - "mysql -e \"DELETE FROM mysql.user WHERE User='';\""
@@ -84,27 +86,28 @@
     - touch ~/mysql_secure_installation
 
 - name: Create MariaDB service dir
-  file:
+  ansible.builtin.file:
     path: /etc/systemd/system/mariadb.service.d/
     state: directory
     mode: 0755
 
 - name: Create MariaDB service override
-  copy:
+  ansible.builtin.copy:
     src: files/override.conf
     dest: /etc/systemd/system/mariadb.service.d/override.conf
+    mode: 0644
   notify:
-    - restart mariadb
-    - daemon-reload
+    - Restart mariadb
+    - Daemon-reload
 
-- name: install backup script
-  copy:
+- name: Install backup script
+  ansible.builtin.copy:
     src: files/backup_mysql.sh
     dest: /usr/local/bin/backup_mysql.sh
     mode: '0755'
 
-- name: cron backup script
-  cron:
+- name: Cron backup script
+  ansible.builtin.cron:
     name: "MariaDB backup"
     hour: "{{ mariadb_backup_hour }}"
     minute: "{{ mariadb_backup_minute }}"