style: make ansible-lint happier

roles/nginx/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 
-- name: restart nginx
+- name: Restart nginx
-  service:
+  ansible.builtin.service:
     name: nginx
     state: restarted

roles/nginx/tasks/main.yml

@@ -1,21 +1,22 @@
 ---
 
-- name: install nginx package
+- name: Install nginx package
-  package:
+  ansible.builtin.package:
     name: nginx-full
     state: present
 
-- name: create dhparam
+- name: Create dhparam
-  shell: /usr/bin/openssl dhparam -out /etc/nginx/dhparam.pem 2048
+  ansible.builtin.command:
-  args:
+    cmd: /usr/bin/openssl dhparam -out /etc/nginx/dhparam.pem 2048
     creates: /etc/nginx/dhparam.pem
 
-- name: put configuration files
+- name: Put configuration files
-  template:
+  ansible.builtin.template:
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
+    mode: 0644
   notify:
-    - restart nginx
+    - Restart nginx
   loop:
     - {src: nginx.conf.j2, dest: /etc/nginx/nginx.conf}
     - {src: nginx.ssl.conf.j2, dest: /etc/nginx/nginx.ssl.conf}
@@ -23,20 +24,21 @@
     - {src: proxy_params.j2, dest: /etc/nginx/proxy_params}
     - {src: default.j2, dest: /etc/nginx/sites-available/default}
 
-- name: create base dir
+- name: Create base dir
-  file:
+  ansible.builtin.file:
     path: /srv/http
     owner: root
     group: www-data
     mode: 'u+rwx,g+rs,o-rwx'
     state: directory
 
-- name: create letsencrypt dir
+- name: Create letsencrypt dir
-  file:
+  ansible.builtin.file:
     path: /srv/http/common/letsencrypt
     owner: root
     group: www-data
     mode: 'u+rwx,g+rs,o-rwx'
     state: directory
 
-- include_tasks: vhosts.yml
+- name: Include vhosts
+  ansible.builtin.include_tasks: vhosts.yml

roles/nginx/tasks/vhosts.yml

@@ -1,20 +1,21 @@
 ---
 
-- name: symlink vhosts
+- name: Symlink vhosts
-  file:
+  ansible.builtin.file:
     src: "/etc/nginx/sites-available/{{ item }}.conf"
     dest: "/etc/nginx/sites-enabled/{{ item }}.conf"
     force: true
     follow: false
     state: link
   notify:
-    - restart nginx
+    - Restart nginx
   loop: "{{ web_hostname }}"
 
-- name: install vhosts
+- name: Install vhosts
-  template:
+  ansible.builtin.template:
     src: "vhosts/{{ item }}.conf.j2"
     dest: "/etc/nginx/sites-available/{{ item }}.conf"
+    mode: 0644
   notify:
-    - restart nginx
+    - Restart nginx
   loop: "{{ web_hostname }}"

roles/nut_client/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 
-- name: restart nut-client
+- name: Restart nut-client
-  service:
+  ansible.builtin.service:
     name: nut-client
     state: restarted

roles/nut_client/tasks/main.yml

@@ -1,21 +1,21 @@
 ---
 
-- name: install nut client
+- name: Rnstall nut client
-  package:
+  ansible.builtin.package:
     name: nut-client
     state: present
 
-- name: upsmon.conf file
+- name: Upsmon.conf file
-  template:
+  ansible.builtin.template:
     src: upsmon.conf.j2
     dest: /etc/nut/upsmon.conf
     mode: '0640'
-  notify: restart nut-client
+  notify: Restart nut-client
 
-- name: nut.conf file
+- name: Nut.conf file
-  copy:
+  ansible.builtin.copy:
     src: files/nut.conf
     dest: /etc/nut/nut.conf
     mode: '0640'
   when: inventory_hostname not in groups['nut_server']
-  notify: restart nut-client
+  notify: Restart nut-client

roles/nut_server/handlers/main.yml

@@ -1,14 +1,16 @@
 ---
 
-- name: restart nut-server
+- name: Restart nut-server
-  service:
+  ansible.builtin.service:
     name: nut-server
     state: restarted
 
-- name: udev
+- name: Udev
-  command: "udevadm control --reload-rules && udevadm trigger"
+  ansible.builtin.command:
+    cmd: "udevadm control --reload-rules && udevadm trigger"
+  changed_when: false
 
-- name: restart nut-driver
+- name: Restart nut-driver
-  service:
+  ansible.builtin.service:
     name: nut-driver
     state: restarted

roles/nut_server/tasks/main.yml

@@ -1,42 +1,43 @@
 ---
 
-- name: install nut server
+- name: Install nut server
-  package:
+  ansible.builtin.package:
     name: nut-server
     state: present
 
-- name: udev conf file for nut
+- name: Udev conf file for nut
-  copy:
+  ansible.builtin.copy:
     src: files/90-nut-ups.rules
     dest: /etc/udev/rules.d/90-nut-ups.rules
+    mode: 0644
   notify:
-    - udev
+    - Udev
-    - restart nut-driver
+    - Restart nut-driver
 
-- name: nut.conf file
+- name: Nut.conf file
-  copy:
+  ansible.builtin.copy:
     src: files/nut.conf
     dest: /etc/nut/nut.conf
     mode: '0640'
-  notify: restart nut-server
+  notify: Restart nut-server
 
-- name: ups.conf file
+- name: Ups.conf file
-  copy:
+  ansible.builtin.copy:
     src: files/ups.conf
     dest: /etc/nut/ups.conf
     mode: '0640'
-  notify: restart nut-server
+  notify: Restart nut-server
 
-- name: upsd.conf file
+- name: Upsd.conf file
-  copy:
+  ansible.builtin.copy:
     src: files/upsd.conf
     dest: /etc/nut/upsd.conf
     mode: '0640'
-  notify: restart nut-server
+  notify: Restart nut-server
 
-- name: upsd.users file
+- name: Upsd.users file
-  template:
+  ansible.builtin.template:
     src: upsd.users.j2
     dest: /etc/nut/upsd.users
     mode: '0640'
-  notify: restart nut-server
+  notify: Restart nut-server

roles/opendkim/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 
-- name: restart opendkim
+- name: Restart opendkim
-  service:
+  ansible.builtin.service:
     name: opendkim
     state: restarted

roles/opendkim/tasks/main.yml

@@ -1,33 +1,36 @@
 ---
 
-- name: install opendkim
+- name: Install opendkim
-  package:
+  ansible.builtin.package:
     name: "{{ item }}"
     state: present
   loop:
     - opendkim
     - opendkim-tools
 
-- name: main configuration files
+- name: Main configuration files
-  template:
+  ansible.builtin.template:
     src: opendkim.conf
     dest: /etc/opendkim.conf
+    mode: 0644
   notify:
-    - restart opendkim
+    - Restart opendkim
 
-- name: dkim directory
+- name: Dkim directory
-  file:
+  ansible.builtin.file:
     path: /etc/dkim
     state: directory
+    mode: 0755
 
-- name: secondary configuration files
+- name: Secondary configuration files
-  copy:
+  ansible.builtin.copy:
     src: "./files/dkim/{{ item }}"
     dest: "/etc/dkim/{{ item }}"
+    mode: 0644
   loop:
     - KeyTable
     - PeerList
     - SigningTable
     - TrustedHosts
   notify:
-    - restart opendkim
+    - Restart opendkim

roles/opendmarc/handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 
-- name: restart opendmarc
+- name: Restart opendmarc
-  service:
+  ansible.builtin.service:
     name: opendmarc
     state: restarted

roles/opendmarc/tasks/main.yml

@@ -1,27 +1,30 @@
 ---
 
-- name: install opendmarc
+- name: Install opendmarc
-  package:
+  ansible.builtin.package:
     name: opendmarc
     state: present
 
-- name: opendmarc config file
+- name: Opendmarc config file
-  copy:
+  ansible.builtin.copy:
     src: ./files/opendmarc.conf
     dest: /etc/opendmarc.conf
+    mode: 0644
   notify:
     - restart opendmarc
 
-- name: dmarc directory
+- name: Dmarc directory
-  file:
+  ansible.builtin.file:
     path: /etc/dmarc
     state: directory
+    mode: 0755
 
-- name: secondary configuration files
+- name: Secondary configuration files
-  copy:
+  ansible.builtin.copy:
     src: "./files/dmarc/{{ item }}"
     dest: "/etc/dmarc/{{ item }}"
+    mode: 0644
   loop:
     - IgnoreHosts
   notify:
-    - restart opendmarc
+    - Restart opendmarc