style: make ansible-lint happier

roles/webapps/handlers/main.yml

@@ -1,11 +1,11 @@
 ---
 
-- name: restart nginx
+- name: Restart nginx
-  service:
+  ansible.builtin.service:
     name: nginx
     state: restarted
 
-- name: restart php-fpm
+- name: Restart php-fpm
-  service:
+  ansible.builtin.service:
     name: "php{{ php_version }}-fpm"
     state: restarted

roles/webapps/tasks/main.yml

@@ -1,25 +1,25 @@
 ---
 
-- name: include ttrss for web1
+- name: Include ttrss for web1
-  include_tasks: ttrss.yml
+  ansible.builtin.include_tasks: ttrss.yml
   when: inventory_hostname == 'web1.dmz.mateu.be'
-- name: include matomo for web2
+- name: Include matomo for web2
-  include_tasks: matomo.yml
+  ansible.builtin.include_tasks: matomo.yml
   when: inventory_hostname == 'web2.dmz.mateu.be'
 - name: WP for NintendojoFR
-  include_tasks: wp_dojo.yml
+  ansible.builtin.include_tasks: wp_dojo.yml
   when: inventory_hostname == 'web2.dmz.mateu.be'
 
 # Scootaloo
 - name: Scootaloo config for m.nintendojo.fr
-  include_tasks: scootaloo_config.yml
+  ansible.builtin.include_tasks: scootaloo_config.yml
   when: inventory_hostname == 'masto1.dmz.mateu.be'
 - name: Scootaloo for Mastodon
-  include_tasks: scootaloo.yml
+  ansible.builtin.include_tasks: scootaloo.yml
   when: inventory_hostname in groups['rorservers']
-- name: tootctl (docker) for mastodon
+- name: Tootctl (docker) for mastodon
-  include_tasks: tootctl_docker.yml
+  ansible.builtin.include_tasks: tootctl_docker.yml
   when: inventory_hostname in groups['dockerservers']
-- name: tootctl (no docker) for mastodon
+- name: Tootctl (no docker) for mastodon
-  include_tasks: tootctl_nodocker.yml
+  ansible.builtin.include_tasks: tootctl_nodocker.yml
   when: inventory_hostname in groups['mastodonservers']

roles/webapps/tasks/matomo.yml

@@ -1,7 +1,7 @@
 ---
 
-- name: crontab for matomo
+- name: Crontab for matomo
-  cron:
+  ansible.builtin.cron:
     name: Matomo reports
     user: www-data
     minute: "5"

roles/webapps/tasks/scootaloo.yml

@@ -1,36 +1,37 @@
 ---
 
-- name: install scootaloo
+- name: Install scootaloo
-  get_url:
+  ansible.builtin.get_url:
     url: "https://r.mateu.be/scootaloo/scootaloo.v{{ scootaloo_version }}"
     dest: "{{ scootaloo_bin_path }}"
     owner: root
     group: www-data
     mode: 0750
 
-- name: create scootaloo config dir
+- name: Create scootaloo config dir
-  file:
+  ansible.builtin.file:
     path: "{{ scootaloo_db_path }}"
     state: directory
     owner: www-data
     group: www-data
     mode: 0750
 
-- name: init scootaloo db
+- name: Init scootaloo db
-  shell:
+  ansible.builtin.command:
     cmd: "{{ scootaloo_bin_path }} init"
     creates: "{{ scootaloo_db_path }}/scootaloo.sqlite"
   become: true
   become_user: www-data
 
-- name: migrate scootaloo db
+- name: Migrate scootaloo db
-  shell:
+  ansible.builtin.command:
     cmd: "{{ scootaloo_bin_path }} migrate"
+  changed_when: false
   become: true
   become_user: www-data
 
-- name: cron for scootaloo
+- name: Cron for scootaloo
-  cron:
+  ansible.builtin.cron:
     name: Scootaloo Dojo
     user: www-data
     minute: "*/{{ scootaloo_min_refresh_interval }}"

roles/webapps/tasks/scootaloo_config.yml

@@ -1,7 +1,7 @@
 ---
 
-- name: put configuration file
+- name: Put configuration file
-  template:
+  ansible.builtin.template:
     src: scootaloo.toml.j2
     dest: /usr/local/etc/scootaloo.toml
     owner: root

roles/webapps/tasks/tootctl_docker.yml

@@ -1,14 +1,14 @@
 ---
 
-- name: cron for media tootctl
+- name: Cron for media tootctl
-  cron:
+  ansible.builtin.cron:
     name: Mastodon tootctl
     minute: "0"
     hour: "2"
     job: "docker-compose -f /srv/docker/{{ web_hostname[0] }}/docker-compose.yml run --rm web bin/tootctl media remove"
 
-- name: cron for preview_cards tootctl
+- name: Cron for preview_cards tootctl
-  cron:
+  ansible.builtin.cron:
     name: Mastodon tootctl preview
     minute: "30"
     hour: "2"

roles/webapps/tasks/tootctl_nodocker.yml

@@ -1,15 +1,15 @@
 ---
 
-- name: cron for media tootctl
+- name: Cron for media tootctl
-  cron:
+  ansible.builtin.cron:
     user: mastodon
     name: Mastodon tootctl
     minute: "0"
     hour: "2"
     job: "{{ mastodon_home }}/bin/remove_media.sh"
 
-- name: cron for preview_cards tootctl
+- name: Cron for preview_cards tootctl
-  cron:
+  ansible.builtin.cron:
     user: mastodon
     name: Mastodon tootctl preview
     minute: "30"

roles/webapps/tasks/ttrss.yml

@@ -1,17 +1,18 @@
 ---
 
-- name: systemd file for backend
+- name: Systemd file for backend
-  copy:
+  ansible.builtin.copy:
     src: files/ttrss_backend.service
     dest: /etc/systemd/system/ttrss_backend.service
+    mode: 0644
 
-- name: enable and start service ttrss_backend
+- name: Enable and start service ttrss_backend
-  service:
+  ansible.builtin.service:
     name: ttrss_backend
     enabled: true
     state: started
 
-- name: install git
+- name: Install git
-  package:
+  ansible.builtin.package:
     name: git
     state: present

roles/webapps/tasks/wp_dojo.yml

@@ -1,14 +1,15 @@
 ---
 
-- name: nginx cache
+- name: Nginx cache
-  copy:
+  ansible.builtin.copy:
     src: files/fastcgi_cache.conf
     dest: /etc/nginx/conf.d/fastcgi_cache.conf
+    mode: 0644
   notify:
     - restart nginx
 
-- name: wordpress cron
+- name: Wordpress cron
-  cron:
+  ansible.builtin.cron:
     name: "WP Twitter refresh"
     user: www-data
     minute: "*/2"