🎨: use ansible.builtin.package with update_cache systematically

roles/bittorrent/tasks/transmission.yml

@@ -2,11 +2,10 @@
 
 - name: Install transmission
   ansible.builtin.package:
-    name: "{{ item }}"
+    name:
+      - transmission-daemon
+      - transmission-cli
     state: present
-  loop:
-    - transmission-daemon
-    - transmission-cli
 
 - name: Put transmission config file
   ansible.builtin.template:

roles/dovecot/tasks/main.yml

@@ -1,12 +1,11 @@
 ---
 - name: Install dovecot
   ansible.builtin.package:
-    name: "{{ item }}"
+    name:
+      - dovecot-imapd
+      - dovecot-sieve
+      - dovecot-lmtpd
     state: present
-  loop:
-    - dovecot-imapd
-    - dovecot-sieve
-    - dovecot-lmtpd
 
 - name: Put main configuration file
   ansible.builtin.copy:

roles/elasticsearch/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: openjdk-17-jre-headless
     state: present
+    update_cache: true
 
 - name: Get elasticsearch key
   ansible.builtin.get_url:
@@ -19,7 +20,7 @@
     mode: "0o644"
 
 - name: Install elasticsearch
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: elasticsearch
     state: present
     update_cache: true

roles/ftp/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: vsftpd
     state: present
+    update_cache: true
 
 - name: Create ftp directory
   ansible.builtin.file:

roles/haproxy/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: haproxy
     state: present
+    update_cache: true
 
 - name: Put haproxy config file
   ansible.builtin.template:

roles/icecast2/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: icecast2
     state: present
+    update_cache: true
 
 - name: Put icecast2 configuration file
   ansible.builtin.template:

roles/mariadb/tasks/main.yml

@@ -6,6 +6,7 @@
       - mariadb-server
       - mysqltuner
     state: present
+    update_cache: true
 
 - name: Create mysql directory
   ansible.builtin.file:
@@ -46,6 +47,7 @@
   ansible.builtin.package:
     name: python3-pymysql
     state: present
+    update_cache: true
 
 - name: Check if .my.cnf file exists
   ansible.builtin.stat:

roles/mastodon/tasks/main.yml

@@ -26,36 +26,36 @@
     group: mastodon
 
 - name: Install prereq
-  ansible.builtin.apt:
-    name: "{{ item }}"
+  ansible.builtin.package:
+    name:
+      - imagemagick
+      - ffmpeg
+      - libpq-dev
+      - libxml2-dev
+      - libxslt1-dev
+      - file
+      - git-core
+      - g++
+      - libprotobuf-dev
+      - protobuf-compiler
+      - pkg-config
+      - nodejs
+      - gcc
+      - autoconf
+      - bison
+      - build-essential
+      - libssl-dev
+      - libyaml-dev
+      - libreadline6-dev
+      - zlib1g-dev
+      - libncurses5-dev
+      - libffi-dev
+      - libgdbm-dev
+      - libidn11-dev
+      - libicu-dev
+      - libjemalloc-dev
     state: present
-  loop:
-    - imagemagick
-    - ffmpeg
-    - libpq-dev
-    - libxml2-dev
-    - libxslt1-dev
-    - file
-    - git-core
-    - g++
-    - libprotobuf-dev
-    - protobuf-compiler
-    - pkg-config
-    - nodejs
-    - gcc
-    - autoconf
-    - bison
-    - build-essential
-    - libssl-dev
-    - libyaml-dev
-    - libreadline6-dev
-    - zlib1g-dev
-    - libncurses5-dev
-    - libffi-dev
-    - libgdbm-dev
-    - libidn11-dev
-    - libicu-dev
-    - libjemalloc-dev
+    update_cache: true
 
 - name: Install rbenv
   ansible.builtin.include_tasks: rbenv.yml

roles/mumble/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: mumble-server
     state: present
+    update_cache: true
 
 - name: Put configuration file
   ansible.builtin.copy:

roles/munin_client/tasks/garage.yml

@@ -1,12 +1,12 @@
 ---
 
 - name: Ensure some packages are installed
-  ansible.builtin.apt:
-    name: "{{ item }}"
+  ansible.builtin.package:
+    name:
+      - curl
+      - jq
     state: present
-  loop:
-    - curl
-    - jq
+    update_cache: true
 
 - name: Put garage plugin configuration
   ansible.builtin.template:

roles/munin_client/tasks/hypervisors.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: nvme-cli
     state: present
+    update_cache: true
 
 - name: Put nvme plugin configuration
   ansible.builtin.template:

roles/munin_client/tasks/main.yml

@@ -20,6 +20,7 @@
   ansible.builtin.package:
     name: "{{ item }}"
     state: present
+    update_cache: true
   loop: "{{ muninpkgs }}"
 
 - name: Put munin-node configuration file
@@ -37,6 +38,7 @@
   ansible.builtin.package:
     name: libwww-perl
     state: present
+    update_cache: true
   notify:
     - Restart munin-node
   when: "'webservers' in group_names or 'loadbalancers' in group_names"
@@ -58,6 +60,7 @@
       - libcache-cache-perl
       - libdbd-mysql-perl
     state: present
+    update_cache: true
   notify:
     - Restart munin-node
   when: "'mariadbservers' in group_names"
@@ -67,6 +70,7 @@
   ansible.builtin.package:
     name: libdbd-pg-perl
     state: present
+    update_cache: true
   notify:
     - Restart munin-node
   when: "'pgsqlservers' in group_names"
@@ -114,8 +118,12 @@
   ansible.builtin.include_tasks: zfs.yml
   when: "'zfsservers' in group_names"
 
-- name: Execute specific physical servers’ commands
-  ansible.builtin.include_tasks: physicalservers.yml
+# Adding modules for physical servers
+- name: Install physical sensors
+  ansible.builtin.package:
+    name: lm-sensors
+    state: present
+    update_cache: true
   when: "'physicalservers' in group_names"
 
 # Specific LXC commands

roles/munin_client/tasks/physicalservers.yml

@@ -1,6 +0,0 @@
----
-
-- name: Install physical sensors
-  ansible.builtin.package:
-    name: lm-sensors
-    state: present

roles/nfs/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: nfs-kernel-server
     state: present
+    update_cache: true
 
 - name: Export FS
   ansible.builtin.template:

roles/nginx/tasks/main.yml

@@ -4,11 +4,13 @@
   ansible.builtin.package:
     name: nginx-full
     state: present
+    update_cache: true
 
 - name: Install nginx extra mods
   ansible.builtin.package:
     name: "libnginx-mod-http-{{ item }}"
     state: present
+    update_cache: true
   loop: "{{ nginx_extra_mods }}"
 
 - name: Create dhparam

roles/nodejs/tasks/main.yml

@@ -24,7 +24,7 @@
     mode: "0o644"
 
 - name: Install nodejs
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: nodejs
     state: present
     update_cache: true

roles/nsd/tasks/prerequisites.yml

@@ -27,3 +27,4 @@
       - ldnsutils
       - cron
     state: present
+    update_cache: true

roles/nut_client/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: nut-client
     state: present
+    update_cache: true
 
 - name: Put upsmon configuration file
   ansible.builtin.template:

roles/nut_server/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: nut-server
     state: present
+    update_cache: true
 
 - name: Put udev configuration file
   ansible.builtin.copy:

roles/opendkim/tasks/main.yml

@@ -2,11 +2,11 @@
 
 - name: Install opendkim
   ansible.builtin.package:
-    name: "{{ item }}"
+    name:
+      - opendkim
+      - opendkim-tools
     state: present
-  loop:
-    - opendkim
-    - opendkim-tools
+    update_cache: true
 
 - name: Put main configuration file
   ansible.builtin.template:

roles/opendmarc/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: opendmarc
     state: present
+    update_cache: true
 
 - name: Put opendmarc configuration file
   ansible.builtin.copy:

roles/peertube/tasks/main.yml

@@ -10,6 +10,7 @@
       - python3-pip
       - unzip
     state: present
+    update_cache: true
 
 - name: Create peertube user
   ansible.builtin.user:

roles/peertube_runner/tasks/main.yml

@@ -2,9 +2,9 @@
 
 - name: Install prerequisites
   ansible.builtin.package:
-    name:
-      - ffmpeg
+    name: ffmpeg
     state: present
+    update_cache: true
 
 - name: Install peertube-runner via npm
   community.general.npm:

roles/php/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: php-fpm
     state: present
+    update_cache: true
 
 - name: Put php-fpm configuration files
   ansible.builtin.template:
@@ -20,6 +21,7 @@
   ansible.builtin.package:
     name: "php-{{ item }}"
     state: present
+    update_cache: true
   loop: "{{ php_modules }}"
   notify:
     - Restart php-fpm

roles/postfix/tasks/main.yml

@@ -1,14 +1,12 @@
 ---
 
-- name: Install postfix
+- name: Install postfix + mailutils
   ansible.builtin.package:
-    name: postfix
-    state: present
-
-- name: Install mailutils
-  ansible.builtin.package:
-    name: mailutils
+    name:
+      - postfix
+      - mailutils
     state: present
+    update_cache: true
 
 - name: Put main configuration files
   ansible.builtin.copy:

roles/postgres/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: postgresql
     state: present
+    update_cache: true
 
 - name: Create pgsql directory
   ansible.builtin.file:

roles/postgrey/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: postgrey
     state: present
+    update_cache: true
 
 - name: Put main configuration files
   ansible.builtin.copy:

roles/redis/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install redis
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: redis
     state: present
     update_cache: true

roles/rsyslog/tasks/main.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: rsyslog
     state: present
+    update_cache: true
 
 - name: Put log configuration file
   ansible.builtin.copy:

roles/smart/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install SMART
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: smartmontools
     state: present
     update_cache: true

roles/smtprelay/tasks/main.yml

@@ -15,6 +15,7 @@
       - postfix
       - libsasl2-modules
     state: present
+    update_cache: true
 
 - name: Put sasl_passwd configuration file
   ansible.builtin.template:

roles/smtprelay/tasks/stunnel.yml

@@ -4,6 +4,7 @@
   ansible.builtin.package:
     name: stunnel4
     state: present
+    update_cache: true
 
 - name: SMTP wrapper
   ansible.builtin.template:

roles/spamassassin/tasks/main.yml

@@ -2,13 +2,13 @@
 
 - name: Install spamassassin
   ansible.builtin.package:
-    name: "{{ item }}"
+    name:
+      - spamassassin
+      - spamass-milter
+      - libmail-dkim-perl
+      - libmail-spf-perl
     state: present
-  loop:
-    - spamassassin
-    - spamass-milter
-    - libmail-dkim-perl
-    - libmail-spf-perl
+    update_cache: true
 
 - name: Put configuration files for spamassassin
   ansible.builtin.copy:

roles/system/tasks/main.yml

@@ -18,16 +18,17 @@
       - wget
       - ncdu
     state: present
+    update_cache: true
 
 - name: Install hypervisors’ specific utilities
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: fuse-overlayfs
     state: present
     update_cache: true
   when: "'hypervisors' in group_names"
 
 - name: Install physical servers’ specific utilities
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: lshw
     state: present
     update_cache: true

roles/tuned/tasks/main.yml

@@ -1,13 +1,12 @@
 ---
 
 - name: Install tuned
-  ansible.builtin.apt:
-    name: "{{ item }}"
+  ansible.builtin.package:
+    name:
+      - tuned
+      - tuned-utils
     state: present
     update_cache: true
-  loop:
-    - tuned
-    - tuned-utils
 
 - name: Put config files
   ansible.builtin.copy:

roles/xmpp/tasks/main.yml

@@ -2,11 +2,11 @@
 
 - name: Install prosody
   ansible.builtin.package:
-    name: "{{ item }}"
+    name:
+      - prosody
+      - prosody-modules
     state: present
-  loop:
-    - prosody
-    - prosody-modules
+    update_cache: true
 
 - name: Create dhparam
   ansible.builtin.command:

roles/yarn/tasks/main.yml

@@ -19,7 +19,7 @@
     mode: "0o644"
 
 - name: Install yarn
-  ansible.builtin.apt:
+  ansible.builtin.package:
     name: yarn
     state: present
     update_cache: true

roles/zfs/tasks/main.yml

@@ -17,13 +17,12 @@
     mode: "0o640"
 
 - name: Install ZFS
-  ansible.builtin.apt:
-    name: "{{ item }}"
+  ansible.builtin.package:
+    name:
+      - dpkg-dev
+      - linux-headers-generic
+      - linux-image-generic
+      - zfs-dkms
+      - zfsutils-linux
     state: present
     update_cache: true
-  loop:
-    - dpkg-dev
-    - linux-headers-generic
-    - linux-image-generic
-    - zfs-dkms
-    - zfsutils-linux